-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event handler errors are silently swallowed #187
Comments
msssk
added a commit
to msssk/dstore
that referenced
this issue
Feb 18, 2020
Very annoying bug, it's very hard to hunt bugs - swallowed errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
return
statement inside thefinally
block in theemit
causes thrown errors to be caught and silently ignored:https://github.com/SitePen/dstore/blob/1.x/Store.js#L141
Ideally it would be nice if we were not catching errors at all, to avoid interrupting the error stack, but at the very least if we are going to be catching errors, we should at least report them with some console output so they don't just silently disappear.
The text was updated successfully, but these errors were encountered: