Properly calculate weekly day codes from start week timestamp #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because start week timestamp is in local timezone, just adding 86400 is not correct in regions with daylight savings time. See SimpleMobileTools/Simple-Calendar#2211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2211
Since the start week timestamp is in the local timezone (see #2154), just adding 86400 to get the next day timestamp is not correct in regions with daylight savings time. This PR basically replaces
weekTimestamp + index * 86400withweekDateTime.plusDays(index).seconds()to delegate the offset calculation to Joda time.