-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to View binding, SDK 34 and Version catalogs #2189
Merged
tibbi
merged 19 commits into
SimpleMobileTools:master
from
FossifyOrg:sdk_and_viewbinding_migration
Sep 5, 2023
Merged
Migrate to View binding, SDK 34 and Version catalogs #2189
tibbi
merged 19 commits into
SimpleMobileTools:master
from
FossifyOrg:sdk_and_viewbinding_migration
Sep 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibbi
reviewed
Sep 3, 2023
app/src/main/kotlin/com/simplemobiletools/calendar/pro/activities/MainActivity.kt
Outdated
Show resolved
Hide resolved
tibbi
reviewed
Sep 3, 2023
app/src/main/kotlin/com/simplemobiletools/calendar/pro/fragments/WeekFragment.kt
Outdated
Show resolved
Hide resolved
- Use `USE_EXACT_ALARM` permission on API 33 and above - Degrade to `setAndAllowWhileIdle` just in case `canScheduleExactAlarms()` returns false on some wierd device
Did the usual tests and nothing looks broken, tested upgrading from the last release too |
the displayed day count at the bottom right corner of weekly view doesnt change colors on light/dark theme on resume |
I'm checking it... |
Fixed it |
ok nice thanks, havent found other issues so will accept it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
AlarmManager.canScheduleExactAlarm()
returns false,setAndAllowWhileIdle()
is used to ensure the functionality isn't broken. This should only happen on Android 12 when the user revokes this permission manually.Minor changes:
item_autocomplete_email_binding.xml
,item_autocomplete_email_name.xml
in favor ofitem_autocomplete_title_subtitle.xml