Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to View binding, SDK 34 and Version catalogs #2189

Merged

Conversation

naveensingh
Copy link
Contributor

@naveensingh naveensingh commented Sep 3, 2023

Major changes:

  • Migrate build scripts from Groovy to Kotlin DSL
  • Migrate to Gradle version catalogs
  • Migrate from Kotlin Kapt to KSP (Kotlin symbol processing) as Kapt is now in maintenance mode.
  • Migrate from Kotlin synthetics to View binding.
  • Target SDK 34:
    • SCHEDULE_EXACT_ALARM was removed on API 33 and above in favor of USE_EXACT_ALARM because it's a normal permission and granted on install but apps are not allowed to use this permission unless their core functionality depends on it (this app qualifies). WheneverAlarmManager.canScheduleExactAlarm() returns false,setAndAllowWhileIdle() is used to ensure the functionality isn't broken. This should only happen on Android 12 when the user revokes this permission manually.
    • No other changes are required.

Minor changes:

  • Fix paddings in the landscape year fragment layout, it's aligned now and the months start in the same row.
  • Remove item_autocomplete_email_binding.xml, item_autocomplete_email_name.xml in favor of item_autocomplete_title_subtitle.xml

@naveensingh naveensingh marked this pull request as ready for review September 5, 2023 12:16
@naveensingh
Copy link
Contributor Author

Did the usual tests and nothing looks broken, tested upgrading from the last release too

@tibbi
Copy link
Contributor

tibbi commented Sep 5, 2023

the displayed day count at the bottom right corner of weekly view doesnt change colors on light/dark theme on resume

@naveensingh
Copy link
Contributor Author

I'm checking it...

@naveensingh
Copy link
Contributor Author

Fixed it

@tibbi
Copy link
Contributor

tibbi commented Sep 5, 2023

ok nice thanks, havent found other issues so will accept it

@tibbi tibbi merged commit e9e887f into SimpleMobileTools:master Sep 5, 2023
@naveensingh naveensingh deleted the sdk_and_viewbinding_migration branch September 5, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants