-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Occasional crash on TF2 just before map switch. (And sometimes during) #3
Comments
Thank you for reporting these issues. Lets see if we can narrow the problem down a bit (aka time to play 50 questions!) since it could be something small and generally inane that could be causing the crashes:
Its okay if you don't know the answers to the above, but even the most insignificant detail could be key to figuring out the crash. Being that its occurring on map change or just before the map changes, it could be a number of things occurring at the time that lead to said crash. |
I don't think there's an interval of time. I've had the crash happen on CTF, CP, and misc maps... so I doubt it has to do with the gametype, but may be worth checking. I find it happens most when transitioning between groups, but that may be coincidental. I have some maps with really long filenames, like mario_dm_mariokart_2014_super_v2 (which is 32 characters!), and ctf_facing_worlds_2011. The server has every stock TF2 map in the cycle, among dozens of custom ones. I don't use workshop, I manually upload my maps. I have the default 3 rounds set. If I manage to grab a crash dump from accelerator, would that help? |
A few crash dumps from accelerator might be helpful in pin pointing the problem. |
Odd, it happened again, but it was on a map with a name not very long, and it didn't produce a crash dump on accelerator either (happened when I transitioned from dm_blockfort to trade_clocktown_v1a, two maps on different gametypes). (And I'm pretty sure accelerator is working... has no problems making dumps if it's something like a bad entity model or whatever.) |
BTW, this is what my mapcycle looks like:
|
Thank you for sharing your map cycle file. After looking over this and doing some digging there are a number of conclusions I have come to and information that I can provide. A lot of this will be conjecture/assumptions, but considering the depth of the problem, the mitigation/solution to this issue might be among the various considerations established below. This will be a long post with a lot of tech jargon (sorry in advance). Its a lot of ground to cover, but I hope that it is informative/helpful. Lets dive into the potential problems:
With the above in mind, there are a few possible mitigations to this issue:
In the end, most of the mitigations/solutions are not exactly easy things to do, require a lot of work, and may not actually fix the problem (though in all likelihood will reduce the occurrence of said issue). Because we are not sure of the specifics of this crash, pinpointing the actual cause of the crash will help in solving it. Assuming the problem is UMC itself, the best solution would be a re-write/new map plugin based on UMC's feature set if the problem is how UMC parses maps, commands, and other such things. However, this would realistically take a long time to accomplish. While better as a long term solution, it might not happen any time soon (time constraints and such for myself or possibly other modders would make getting a working solution more difficult on top of design of the plugin and what features will/won't get added etc.) so it would not solve the immediate problem in the short term, which does not help with the problem currently being experience right now. For short term results, the other mitigations may help reduce the likelihood of a crash being caused by certain aspects of UMC and/or other plugins and configurations being loaded by simplifying what is being run/used on the server. This assumes that UMC is only part of the problem but not truly the root cause. For example, it could very well be that UMC is working correctly, but because other plugins and configs are running and doing a lot of stuff in the background simultaneously to UMC, the problem that occurs during a map change might be happening when the UMC plugin loads new configs and commands before or after map change, which could be causing the crash as well. Because its occurrence is occasional and does not happen often or every time after a set period of time/map changes, this leads me to believe that UMC is not necessarily the issue specifically, but in all likelihood a part of the overall problem that results in a crash. For now, I will work on the other issues in an attempt fix those, but I believe this issue is more complex and will ultimately take more time/information to pinpoint and resolve the specific issue. It could very well be a possibility that I cannot resolve it due to the plugin's design which might require a re-write or a completely new plugin. I will leave this issue open in case more information is available, but I cannot guarantee a quick/meaningful resolution to this issue at this time. |
Speaking of new plugins, I've long wanted someone to make an extension for Mapchooser Extended that allows you to vote for a config, or a mapcycle file (changing the mapcyclefile cvar), before the main map vote, because at least there, I know it's stable. I don't crash if I'm not using UMC. Perhaps adding maprate-based map weighting and sorting to MCE's core as well. Anyhow, I did get one crash dump on map change, dunno if it's relevant: https://crash.limetech.org/n52leil4o2oy |
#3 submitted to GitHub. See README.md Signed-off-by: Mr.Silence <[email protected]>
This bug is more of a plugin design flaw than a bug and it is something that can't be easily fixed. It seems, after looking into this as well as reading up on several posts, that the main culprit is the Display options used in the UMC mapcycle file to change the name of the map. Others that can help make this issue worse is too many maps/groups in the mapcycle file. In order to avoid or lessen the impact, it is advised to do the following:
In general, it is better to keep things simple since the more large and complex the UMC mapcycle becomes, the more likely that the plugin will become unstable due to having to parse through various options and features all at once. Reducing complexity will generally help out more than reducing the number of maps as some users reported having very large map selections without having issues. Closing issue. |
UMC seems to randomly crash TF2 servers just before the map transition. It's rare, but it happens. Can't share more detail because I can't really get a bead on what may be causing it. Seems to happen either just before the scoreboard is shown, or when it tries to switch.
The text was updated successfully, but these errors were encountered: