-
Notifications
You must be signed in to change notification settings - Fork 44.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inverted logic for deny_command #4563
Fix inverted logic for deny_command #4563
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4563 +/- ##
==========================================
+ Coverage 69.38% 69.52% +0.14%
==========================================
Files 72 72
Lines 3551 3551
Branches 569 569
==========================================
+ Hits 2464 2469 +5
+ Misses 895 892 -3
+ Partials 192 190 -2
☔ View full report in Codecov by Sentry. |
c050863
to
daea656
Compare
Deployment failed with the following error:
|
761ab7b
to
f7b7465
Compare
f7b7465
to
cd9f715
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (mostly). If you adjust the test to make it a bit less picky we can merge.
cd9f715
to
875ab46
Compare
Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: k-boikov <[email protected]> Co-authored-by: merwanehamadi <[email protected]> Co-authored-by: Merwane Hamadi <[email protected]> Co-authored-by: Richard Beales <[email protected]> Co-authored-by: Luke K <[email protected]> Co-authored-by: Luke K (pr-0f3t) <[email protected]> Co-authored-by: Erik Peterson <[email protected]> Co-authored-by: Auto-GPT-Bot <[email protected]> Co-authored-by: Benny van der Lans <[email protected]> Co-authored-by: Jan <[email protected]> Co-authored-by: Robin Richtsfeld <[email protected]> Co-authored-by: Marc Bornträger <[email protected]> Co-authored-by: Stefan Ayala <[email protected]> Co-authored-by: javableu <[email protected]> Co-authored-by: DGdev91 <[email protected]> Co-authored-by: Kinance <[email protected]> Co-authored-by: digger yu <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: gravelBridge <[email protected]> Fix Python CI "update cassettes" step (#4591) fix CI (#4596) Fix inverted logic for deny_command (#4563) fix current_score.json generation (#4601) Fix duckduckgo rate limiting (#4592) Fix debug code challenge (#4632) Fix issues with information retrieval challenge a (#4622) fix issues with env configuration and .env.template (#4630) Fix prompt issue causing 'No Command' issues and challenge to fail (#4623) Fix benchmark logs (#4653) Fix typo in docs/setup.md (#4613) Fix run.sh shebang (#4561) Fix autogpt docker image not working because missing prompt_settings (#4680) Fix execute_command coming from plugins (#4730)
Background
deny_command
is inverted. Before this changedeny_command
didn't work as expected.Changes
deny_command
check so that it returnsFalse
if the command includes adeny_command
Documentation
Test Plan
PR Quality Checklist