[bug] list_files
api signature change in data_ingestion.py
and lo…
#3601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list_files
api signature change indata_ingestion.py
and fix logging related bugs indata_ingestion.py
Background
Integrating #3595 led to an API change that created an
ImportError
indata_ingestion.py
. Integrating #3056 created a ValueError with theconfigure_logging
function becausefilemode
is an invalid argument:The
data_ingestion.py
file is also not usable when usingLocalCache
memory since theConfig
object has noworkspace_path
set to it. I can send a follow up PR that adds this option. Let me know if that is a direction you wish to support.Changes
This PR fixes two bugs in the
data_ingestion.py
that made it un-callable.Documentation
Test Plan
PR Quality Checklist