Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend & improve file operations tests #3404

Merged
merged 4 commits into from
Apr 29, 2023
Merged

Extend & improve file operations tests #3404

merged 4 commits into from
Apr 29, 2023

Conversation

k-boikov
Copy link
Contributor

@k-boikov k-boikov commented Apr 27, 2023 •
edited
Loading

Background

Try to improve code coverage.
Switch from Unittest to Pytest

Changes

Migrate tests for file operations

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 29, 2023 2:43pm

@k-boikov k-boikov force-pushed the improvement/file-operations-tests branch from 91d1563 to 1575279 Compare April 27, 2023 13:46
@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.07 🎉

Comparison is base (9c6494a) 57.19% compared to head (857992c) 58.26%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3404      +/-   ##
==========================================
+ Coverage   57.19%   58.26%   +1.07%     
==========================================
  Files          68       68              
  Lines        3079     3079              
  Branches      516      516              
==========================================
+ Hits         1761     1794      +33     
+ Misses       1180     1148      -32     
+ Partials      138      137       -1
Impacted Files Coverage Δ
autogpt/commands/file_operations.py 83.59% <100.00%> (+25.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k-boikov k-boikov marked this pull request as ready for review April 27, 2023 13:50
roeiba
roeiba previously approved these changes Apr 27, 2023
View reviewed changes
Pwuts
Pwuts requested changes Apr 27, 2023
View reviewed changes
tests/unit/test_file_operations.py Outdated Show resolved Hide resolved
@Pwuts Pwuts self-assigned this Apr 27, 2023
@k-boikov k-boikov force-pushed the improvement/file-operations-tests branch from 9d6eefc to 9d917a7 Compare April 27, 2023 22:01
@github-actions github-actions bot added size/xl and removed size/m labels Apr 27, 2023
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@k-boikov k-boikov force-pushed the improvement/file-operations-tests branch from 9d917a7 to cb70c4b Compare April 27, 2023 22:05
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@k-boikov k-boikov force-pushed the improvement/file-operations-tests branch 2 times, most recently from eab45e7 to 381393c Compare April 27, 2023 22:25
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@k-boikov k-boikov force-pushed the improvement/file-operations-tests branch from 381393c to 44622b1 Compare April 28, 2023 12:10
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@k-boikov k-boikov force-pushed the improvement/file-operations-tests branch from 44622b1 to c94cf64 Compare April 28, 2023 12:33
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

Pwuts
Pwuts requested changes Apr 28, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_file_operations.py Outdated Show resolved Hide resolved
tests/test_file_operations.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 28, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@k-boikov k-boikov force-pushed the improvement/file-operations-tests branch from c94cf64 to d1ac531 Compare April 28, 2023 17:25
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 28, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@Pwuts Pwuts changed the title Improvement/file operations tests Extend & improve file operations tests Apr 29, 2023
@Pwuts Pwuts merged commit 2d058fe into Significant-Gravitas:master Apr 29, 2023
dschonholtz pushed a commit to dschonholtz/Auto-GPT that referenced this pull request Apr 29, 2023
@k-boikov @Pwuts @dschonholtz
Extend & improve file operations tests (Significant-Gravitas#3404)
f9f70bc 
Co-authored-by: Reinier van der Leer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pwuts Pwuts Pwuts approved these changes

@roeiba roeiba roeiba left review comments

Assignees

@Pwuts Pwuts

Labels
size/xl testing
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-boikov @roeiba @Pwuts