Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-work Docs and split out README (using MkDocs) #2894

Merged
merged 12 commits into from
Apr 22, 2023
Merged

Re-work Docs and split out README (using MkDocs) #2894

merged 12 commits into from
Apr 22, 2023

Conversation

richbeales
Copy link
Contributor

@richbeales richbeales commented Apr 22, 2023

Background

The README is too long, and difficult to read/maintain. Split into separate markdown files in the /docs folder. Set up mkdocs to host a static site on github pages.

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (b4bd11d) 36.29% compared to head (0134a3e) 36.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2894      +/-   ##
==========================================
- Coverage   36.29%   36.22%   -0.08%     
==========================================
  Files          60       60              
  Lines        2849     2849              
  Branches      471      471              
==========================================
- Hits         1034     1032       -2     
- Misses       1753     1755       +2     
  Partials       62       62              

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richbeales richbeales added the documentation Improvements or additions to documentation label Apr 22, 2023
README.md Outdated Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
docs/plugins.md Outdated Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
@ntindle ntindle mentioned this pull request Apr 22, 2023
1 task
docs/plugins.md Outdated Show resolved Hide resolved
docs/plugins.md Outdated Show resolved Hide resolved
Copy link
Member

@ntindle ntindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, few changes requested

@richbeales richbeales requested a review from ntindle April 22, 2023 09:08
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@p-i- p-i- merged commit ad5d8b2 into master Apr 22, 2023
@p-i- p-i- deleted the docs branch April 22, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants