Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Continuous Integration Automatic #2327

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Make Continuous Integration Automatic #2327

merged 2 commits into from
Apr 18, 2023

Conversation

Torantulino
Copy link
Member

Background

CI currently does not run automatically, instead needs manual execution.

Changes

Aims to make CI on PRs run automatically

Test Plan

Untested

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@Torantulino Torantulino changed the title Change on PR to all branches Make Continuous Integration Automatic Apr 18, 2023
richbeales
richbeales previously approved these changes Apr 18, 2023
@Torantulino
Copy link
Member Author

Torantulino commented Apr 18, 2023

I'm not sure if this solves the problem or not.
It depends on whether "branch" is referring to the branch the PR is merging into, or the branch on the fork.

Edit:

pull_request_target is a separate field, adding both should hopefully solve this.

@Torantulino
Copy link
Member Author

Summary of changes:

  • The first patch changes the pull_request section in the ci.yml file to trigger builds for all branches, not just the master branch.
  • The second patch adds a new pullrequesttarget event to trigger CI for pull requests that come from forks of the main repository.

@richbeales richbeales merged commit 4c2a566 into master Apr 18, 2023
@Pwuts
Copy link
Member

Pwuts commented Apr 18, 2023

branch refers to the target branch of the pull request, so branches: [master] is sensible there.

@richbeales richbeales deleted the automatic-CI branch April 20, 2023 04:42
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
…s/automatic-CI

Make Continuous Integration Automatic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants