Fix duplicate all
signature in Active Record relations DSL compiler
#1940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I think rails/rails@fd5bd98 introduced a subtle change to
ActiveRecord::QueryMethods
which resulted in duplicate type signatures forGeneratedAssociationRelationMethods
.Implementation
Preserve the custom definition and remove
:all
from query methods.Tests
The tests for this DSL compiler appear to be failing on Rails Edge with a couple issues:
This PR at least addresses the duplicate type signature which will cause static type-checking issues.