Handle rate limiting by sleeping required amount #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
force-pushed
the
handle-rate-limit
branch
2 times, most recently
from
2a2f2aa
to
1756592
Compare
kmcphillips
approved these changes
May 21, 2024
lib/smart_todo/slack_client.rb
Outdated
|
|
||
| slack_response!(response) | ||
| end | ||
| while response.is_a?(Net::HTTPTooManyRequests) && attempts < 5 |
There was a problem hiding this comment.
But I'd put this in a const or def dispatch(request, max_attempts=5)
lib/smart_todo/slack_client.rb
Outdated
| slack_response!(response) | ||
| end | ||
| while response.is_a?(Net::HTTPTooManyRequests) && attempts < 5 | ||
| sleep(Integer(response["Retry-After"])) |
There was a problem hiding this comment.
To be real safe, and guard against some eccentric response or parsed value, you could do:
sleep(min(Integer(response["Retry-After"]), SOME_SAFE_MAXIMUM_SECONDS))
kddnewton
force-pushed
the
handle-rate-limit
branch
2 times, most recently
from
b5c4b16
to
2138a9f
Compare
kddnewton
force-pushed
the
handle-rate-limit
branch
from
2138a9f
to
c01327f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.