Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the read_orders scope from list of default scopes provided to a generated app #629

Merged
merged 2 commits into from
Oct 15, 2018

Conversation

TerencedzLi
Copy link
Contributor

With reference to: Issue

@TerencedzLi TerencedzLi self-assigned this Sep 5, 2018
@vfonic
Copy link
Contributor

vfonic commented Sep 6, 2018

There are couple of more read_orders in the scope throughout the codebase. To find them all, it's the best to do a project-wide search for read_orders.

@TerencedzLi
Copy link
Contributor Author

AFAIK, the remaining references are either to showcase usage of scopes (in docs) or a part of some tests that allow you to specify scopes to be used (i.e for CLI)

@tylerball
Copy link
Contributor

I don't have a lot of context here but I think we should have a plan to update those docs as well.

@TerencedzLi
Copy link
Contributor Author

TerencedzLi commented Sep 11, 2018

Note to self: Here's one part of the documentation that needs to be updated. https://help.shopify.com/en/api/getting-started/authentication/public-authentication

Node example docs only use read_products. https://help.shopify.com/en/api/tutorials/building-node-app

@jamiemtdwyer
Copy link
Contributor

jamiemtdwyer commented Oct 15, 2018

Note to self: Here's one part of the documentation that needs to be updated. https://help.shopify.com/en/api/getting-started/authentication/public-authentication

Node example docs only use read_products. https://help.shopify.com/en/api/tutorials/building-node-app

I don't see any reason why any documentation on the help site would need to be updated, including either of these.

There are no tutorials or guides on the help site that use shopify_app.

@TerencedzLi
Copy link
Contributor Author

Note to self: Here's one part of the documentation that needs to be updated. https://help.shopify.com/en/api/getting-started/authentication/public-authentication
Node example docs only use read_products. https://help.shopify.com/en/api/tutorials/building-> node-app

I don't see any reason why any documentation on the help site would need to be updated, including either of these.

There are no tutorials or guides on the help site that use shopify_app.

Yeaup, those links I put are irrelevant. But as a whole effort, as seen in the initial issue, we wanted to remove read_orders as a default scope. I agree probably not relevant to this gem :) thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants