Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests: reset ShopifyApp configuration before each test #429

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Improve tests: reset ShopifyApp configuration before each test #429

merged 1 commit into from
Jul 10, 2017

Conversation

Hammadk
Copy link
Member

@Hammadk Hammadk commented Jul 10, 2017

Problem

Tests have to reset the default ShopifyApp.configuration to prevent leaky tests. This means that more context is required when writing tests, and more boilerplate code.

Suggested Solution

Set the default configuration with ShopifyAppConfigurer.call before each test.

@Hammadk Hammadk merged commit 5c22195 into master Jul 10, 2017
@Hammadk Hammadk deleted the set-default-config-for-tests branch July 10, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmalette gmalette gmalette approved these changes

@kevinhughes27 kevinhughes27 kevinhughes27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hammadk @gmalette @kevinhughes27 @ccleung