Update LoginProtection#fullpage_redirect_to to get shopify domain from session #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhughes27
approved these changes
Apr 10, 2017
…rect for non-embedded apps
Hammadk
changed the title
|
@kevinhughes27 can you please give this another look. The last two commits fixed leaky tests that were setting |
kevinhughes27
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #398 we found that
fullpage_redirect_tocannot be used when the:shopparam is not present and the shop is already logged in. This PR solves this problem by grabbing the domain from the session.At this point I am not sure if there is a better method of grabbing the domain. Another option is to
ShopifyApp::SessionRepository.retrieve(session[:shopify]).shopify_domainSidenote: Our setup for
LoginProtectionTestsis pretty weird. I'd like to unit testfullpage_redirect_tobut that's not straight forward.