Remove disable sorbet line from spring command #326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fix disabling sorbet when booting spring. Closes #325
What approach did you choose and why?
Because spring commands are required for any spring boot of an application, we don't want to disable spring for non-packwerk boots (eg. running tests, running the dev server, etc.). So, we removed the require.
What should reviewers focus on?
We still need to find a way to disable sorbet for spring loaded packwerk runs, but I think the binstub that is used in the app may need to be changed by the developer manually. We likely cannot account for this in the gem. More investigation needed.
Type of Change
Additional Release Notes
Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.
If no additional notes are necessary, delete this section or leave it unchanged.
Checklist