Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disable sorbet line from spring command #326

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

gmcgibbon
Copy link
Member

@gmcgibbon gmcgibbon commented Mar 7, 2023

What are you trying to accomplish?

Fix disabling sorbet when booting spring. Closes #325

What approach did you choose and why?

Because spring commands are required for any spring boot of an application, we don't want to disable spring for non-packwerk boots (eg. running tests, running the dev server, etc.). So, we removed the require.

What should reviewers focus on?

We still need to find a way to disable sorbet for spring loaded packwerk runs, but I think the binstub that is used in the app may need to be changed by the developer manually. We likely cannot account for this in the gem. More investigation needed.

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Additional Release Notes

  • Breaking change (fix or feature that would cause existing functionality to change)

Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.

If no additional notes are necessary, delete this section or leave it unchanged.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

Because spring commands are required for _any_ spring boot of an
application, we don't want to disable spring for non-packwerk boots (eg.
running tests, running the dev server, etc.).
@gmcgibbon gmcgibbon requested a review from a team as a code owner March 7, 2023 21:39
@gmcgibbon gmcgibbon merged commit 43ca76f into main Mar 7, 2023
@gmcgibbon gmcgibbon deleted the remove_spring_command_sorbet_disable branch March 7, 2023 22:22
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems March 9, 2023 00:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] packwerk is disabling Sorbet runtime checks, globally on Spring
2 participants