Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_money parse with Money.new when there is no thousand delimiter #309

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

elfassy
Copy link
Contributor

@elfassy elfassy commented Jun 27, 2024

Why

Make "1.123".to_money behave consistently like Money.new(1.123) and have a value of 1.12

What

Remove deprecation warning for apps using legacy_deprecation option, and default to the correct behaviour

Note: This is a BREAKING CHANGE for apps using this option!

@elfassy elfassy changed the base branch from main to v3 June 27, 2024 17:19
@elfassy elfassy added the v3 label Jun 27, 2024
@elfassy
Copy link
Contributor Author

elfassy commented Jun 27, 2024

Copy link
Contributor

@TayKangSheng TayKangSheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfassy elfassy merged commit 03ac4e8 into v3 Jun 27, 2024
9 checks passed
@elfassy elfassy deleted the to_money_return_actual_amount branch June 27, 2024 21:15
@elfassy elfassy mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants