refactor(idpe-17789): rename PartitionStream to CompactionJobStream

Shopify · Jul 25, 2023 · 2f51333 · 2f51333
1 parent 5afc6e6
commit 2f51333
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/compactor/src/components/hardcoded.rs b/compactor/src/components/hardcoded.rs
@@ -64,7 +64,7 @@ use super::{
  metrics::MetricsPartitionSourceWrapper,
  },
  partition_stream::{
- endless::EndlessPartititionStream, once::OncePartititionStream, PartitionStream,
+ endless::EndlessPartititionStream, once::OncePartititionStream, CompactionJobStream,
  },
  post_classification_partition_filter::{
  logging::LoggingPostClassificationFilterWrapper,
@@ -184,7 +184,7 @@ fn make_jobs_source_commit_partition_sink(
 fn make_partition_stream(
  config: &Config,
  compaction_jobs_source: Arc<dyn CompactionJobsSource>,
-) -> Arc<dyn PartitionStream> {
+) -> Arc<dyn CompactionJobStream> {
  if config.process_once {
  Arc::new(OncePartititionStream::new(compaction_jobs_source))
  } else {

diff --git a/compactor/src/components/mod.rs b/compactor/src/components/mod.rs
@@ -6,7 +6,7 @@ use self::{
  file_classifier::FileClassifier, ir_planner::IRPlanner, parquet_files_sink::ParquetFilesSink,
  partition_done_sink::PartitionDoneSink, partition_files_source::PartitionFilesSource,
  partition_filter::PartitionFilter, partition_info_source::PartitionInfoSource,
- partition_stream::PartitionStream,
+ partition_stream::CompactionJobStream,
  post_classification_partition_filter::PostClassificationPartitionFilter,
  round_info_source::RoundInfoSource, round_split::RoundSplit, scratchpad::ScratchpadGen,
 };
@@ -47,7 +47,7 @@ pub mod timeout;
 #[derive(Debug, Clone)]
 pub struct Components {
  /// Source of partitions for the compactor to compact
- pub partition_stream: Arc<dyn PartitionStream>,
+ pub partition_stream: Arc<dyn CompactionJobStream>,
  /// Source of information about a partition neededed for compaction
  pub partition_info_source: Arc<dyn PartitionInfoSource>,
  /// Source of files in a partition for compaction

diff --git a/compactor/src/components/partition_stream/endless.rs b/compactor/src/components/partition_stream/endless.rs
@@ -6,7 +6,7 @@ use futures::{stream::BoxStream, StreamExt};
 use super::super::{
  compaction_jobs_source::CompactionJobsSource, partition_files_source::rate_limit::RateLimit,
 };
-use super::PartitionStream;
+use super::CompactionJobStream;
 
 #[derive(Debug)]
 pub struct EndlessPartititionStream<T>
@@ -38,7 +38,7 @@ where
  }
 }
 
-impl<T> PartitionStream for EndlessPartititionStream<T>
+impl<T> CompactionJobStream for EndlessPartititionStream<T>
 where
  T: CompactionJobsSource,
 {

diff --git a/compactor/src/components/partition_stream/mod.rs b/compactor/src/components/partition_stream/mod.rs
@@ -7,8 +7,8 @@ pub mod endless;
 pub mod once;
 
 /// Source for partitions.
-pub trait PartitionStream: Debug + Display + Send + Sync {
- /// Create new source stream of compaction job.
+pub trait CompactionJobStream: Debug + Display + Send + Sync {
+ /// Create new source stream of compaction jobs.
  ///
  /// This stream may be endless.
  fn stream(&self) -> BoxStream<'_, CompactionJob>;

diff --git a/compactor/src/components/partition_stream/once.rs b/compactor/src/components/partition_stream/once.rs
@@ -3,7 +3,7 @@ use std::{fmt::Display, sync::Arc};
 use compactor_scheduler::CompactionJob;
 use futures::{stream::BoxStream, StreamExt};
 
-use super::{super::compaction_jobs_source::CompactionJobsSource, PartitionStream};
+use super::{super::compaction_jobs_source::CompactionJobsSource, CompactionJobStream};
 
 #[derive(Debug)]
 pub struct OncePartititionStream<T>
@@ -33,7 +33,7 @@ where
  }
 }
 
-impl<T> PartitionStream for OncePartititionStream<T>
+impl<T> CompactionJobStream for OncePartititionStream<T>
 where
  T: CompactionJobsSource,
 {