Return proper errors in LoadFile and LoadString #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlexMax
commented
Jan 26, 2017
- Error messages did not properly chunkID the source filename, leading to @'s next to filenames and such.
- LoadFile improperly raised a generic file read error, even if the actual error was a Lua error such as a SyntaxError.
- Error messages did not properly chunkID the source filename, leading to @'s next to filenames and such. - LoadFile improperly raised a generic file read error, even if the actual error was a Lua error such as a SyntaxError.
fbogsany
reviewed
Feb 7, 2017
auxiliary.go
Outdated
| switch err { | ||
| case nil: // do nothing | ||
| case SyntaxError: // do nothing | ||
| case MemoryError: // do nothing |
There was a problem hiding this comment.
You could merge these cases as:
switch err {
case nil, SyntaxError, MemoryError: // do nothing
default:
...
}
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.