[Cart.js] Fix fetch url so it's not hard coded #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stufreen
suggested changes
Mar 3, 2023
|
The cart works correct now, but the language/currency selectors stopped working for me 🤔 updated: maybe it's a bug on github. I pulled your branch to my local machine and it works fine. So, I thing you can ignore my comment. |
eugenekasimov
approved these changes
Mar 3, 2023
ludoboludo
added a commit
that referenced
this pull request
Mar 6, 2023
pangloss
added a commit
to pangloss/dawn
that referenced
this pull request
Mar 11, 2023
* shopify/main: Improve image sizes in the multicolumn section (Shopify#2349) Fix the Page section's width. (Shopify#2364) Update 12 translation files (Shopify#2366) Removing "my" from cart popup notification (Shopify#2353) [Cart.js] Fix fetch url so it's not hard coded (Shopify#2357) (Shopify#2365) Update 1 translation file (Shopify#2352) Default Follow on Shop to on [Header] Add localization selectors (Shopify#2258) Remove async CSS pattern where it may introduce layout shifts (Shopify#2270) Change rich text section heading to be of type inline_richtext, also moved rte styling into base.css (Shopify#2326) Add drawer menu desktop (Shopify#2195) Make header image preload and proper width (Shopify#2307)
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
…y#2365) * fix fetch url so it's not hard coded * change url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This fixes an issue where when using the cart drawer specifically, the theme wouldn't keep the currency chosen by the user when going to the checkout.
Why are these changes introduced?
Fixes #2356
What approach did you take?
Use dynamic variables we have to set the fetch url.
Other considerations
Decision log
Visual impact on existing themes
NO visual changes.
Testing steps/scenarios
Check this issue for more details.
Demo links
Checklist