change the symlink creation condition #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed laravel's File:exists() wasn't working correctly with symlinks, I changed it with pure php's is_link() function and recombined your condition for more brevity. Please merge it if you agree with this. Thank you!
|
is_link does not work as expected in windows. https://www.php.net/manual/en/function.is-link.php related: #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed laravel's File:exists() wasn't working correctly with symlinks, I changed it with pure php's is_link() function and recombined your condition for more brevity. Please merge it if you agree with this. Thank you!