Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #41

Merged
merged 11 commits into from May 9, 2020
Merged

Fix bugs #41

merged 11 commits into from May 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2020

Hi !

  • As i explained in issue Bug in ThemeGeneratorCommand : title_case #40, the method title_case is not available since 5.7.
    I have changed the method to Str::title.

  • There is another bug : symlink. I have used another name than "Themes", and i had a message error :

symlink(): File exists

Because, it is missing a little condition in :

if (!File::exists(public_path('Themes')) && config('theme.symlink') && File::exists(config('theme.theme_path'))) {

---> As i used another name, with this condition, it checked if "Themes" exists in public path. In my cas, it doesn't exist but it is already symlink with another name. So, on every boot, this class try to symlink to path which is already exist.

I have added a "&& !File::exists(config('theme.symlink_path'))" in this condition.

  • Another bug with other name than "Themes" : getFullPath. This method used the name "Themes" by default if there is a symlink. I fixed it by :

$themePath = str_replace(base_path('public') . DIRECTORY_SEPARATOR, '', $this->config[ 'theme.symlink_path' ]) . DIRECTORY_SEPARATOR.$themeName.DIRECTORY_SEPARATOR;;

  • Clean style ci error

It is now worked with my project ( i use Laravel Framework 7.9.2). (Sorry for multiple commits. It is my first time...)

Best regards.

@ghost ghost changed the title Fix bug : method title_case is not longer available since laravel 5.7 Fix bugs May 1, 2020
@Shipu
Copy link
Owner

Shipu commented May 9, 2020

Thank you so much. and I want to merge your pull request by ignoring your multiple commits

@Shipu Shipu merged commit ebf7b1d into Shipu:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants