Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show ssh-agent failure messages #41

Merged
merged 2 commits into from
Feb 4, 2016
Merged

show ssh-agent failure messages #41

merged 2 commits into from
Feb 4, 2016

Conversation

kanthchandra
Copy link
Contributor

fixes #40

Tested this out by running a pre ci boot image which does not have ssh-agent installed in it. and the build failed telling that ssh-agent command not found.

@ric03uec
Copy link
Contributor

ric03uec commented Feb 3, 2016

@kanthchandra is the ssh-agent not found message being dumped on the job console?
i'm not sure how that is being printed since this check is happening in the python code

@rageshkrishna
Copy link
Contributor

@ric03uec This will show up in the wait_for_exit step where we show the output of docker logs. Because this reports an unrecognized exit code, the boot script recognizes it as a boot failure and the group will be displayed in the console.

@ric03uec
Copy link
Contributor

ric03uec commented Feb 4, 2016

got it. i keep forgetting that part :)
@kanthchandra can you rebase this with the latest cexec.

@@ -150,6 +156,12 @@ def _push_coverage_results(self):
coverage_results['jobId'] = self.job_id
self.shippable_adapter.post_coverage_results(coverage_results)

def _check_for_ssh_agent(self):
self.log.debug('Inside Execute')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong log

ric03uec added a commit that referenced this pull request Feb 4, 2016
show ssh-agent failure messages
@ric03uec ric03uec merged commit 3474222 into Shippable:master Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check if ssh-agent is installed before running the scripts.
3 participants