Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added case for german languaged Worksheets #32

Closed
wants to merge 33 commits into from

Conversation

OliverZ
Copy link
Contributor

@OliverZ OliverZ commented Aug 28, 2013

added case for german languaged Worksheets to not log "Unrecognized key in Heading Pairs" error to console.

@redchair123
Copy link

Can you share a file from a german version of Excel? A blank file is fine, I just want one that shows the German case.

Also, can you also modify the master branch as well? Add the same case in xlsx.js and bits/70_xlsx.js

@OliverZ
Copy link
Contributor Author

OliverZ commented Aug 31, 2013

i added a testfile here

https://github.com/OliverZ/js-xlsx/blob/master/tests/test.xlsx

if you run

var XLSX = require('xlsx')
var xlsx = XLSX.readFile('test.xlsx');
var sheet_name_list = xlsx.SheetNames;
xlsx.SheetNames.forEach(function(y) {
  for (z in xlsx.Sheets[y]) {
    if(z[0] === '!') continue;
    console.log(y + "!" + z + "=" + JSON.stringify(xlsx.Sheets[y][z].v));
  }
});

it will print: Unrecognized key in Heading Pairs

@redchair123
Copy link

I turned off that error message, as it appears to work properly. I'm trying to find a comprehensive list of the possible words, but that is proving hard to find.

clarketm pushed a commit to clarketm/js-xlsx that referenced this pull request Nov 27, 2016
@SheetJSDev SheetJSDev closed this Dec 31, 2016
SheetJSDev pushed a commit that referenced this pull request Mar 25, 2017
Excel localizes "Worksheets" and other names in XLS[XMB] Properties

Fixes #33

note: @OliverZ contributed a file with "Arbeitsblätter"
      @SheetJSDev tested against test suite, PR #32 details used
@SheetJS SheetJS locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants