Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bower.json to main branch to resolve injection issues #48

Merged
merged 1 commit into from
Jul 25, 2014
Merged

Add bower.json to main branch to resolve injection issues #48

merged 1 commit into from
Jul 25, 2014

Conversation

jjstewart
Copy link
Contributor

I was having an issue when running my application using the "grunt serve" terminal command. The xls.js file was not being injected due to the missing "main" entry in the bower.json file. This file should be in the main branch so when the code is packaged it is formatted for use on install.

@SheetJSDev
Copy link
Contributor

@jjstewart thanks for finding the issue and coming up with a pull request :)

The build errors appear to be timeouts (hitting the 2 second limit) unrelated to this.

Do you know if all of those fields are necessary? I wonder if the underscore-prefixed items like _release are needed (the jQuery bower.json https://github.com/jquery/jquery/blob/master/bower.json does not include those)

@jjstewart
Copy link
Contributor Author

@SheetJSDev I went back and looked at the spec again and no those do not appear to be necessary. There is more you can do with this bower.json file as well but I did not want to take liberties with your package. You might want to consider revising the bower.json to use your dist folder and add an ignore property so when the package is installed via Bower it does not clone the entire repo in to the persons project. See http:https://bower.io/docs/creating-packages/ for details.

@jjstewart
Copy link
Contributor Author

@SheetJSDev I made some changes and have tested them locally which all passed. I left the additional sections open as I am not the owner of this repo and would like your imput on what you would like to have ignored and listed as dependencies etc.

@SheetJSDev
Copy link
Contributor

@jjstewart Looks good.

Do you know if there's a way to specify which files you want to include (rather than which files to ignore)? If there is no way, then add bin/*, bits/*, misc/* to the ignore list.

Also, can you squash down to one commit with the message "Add bower.json to resolve injection issues" (to fit within 50 characters)?

@jjstewart
Copy link
Contributor Author

@SheetJSDev Sure thing, it is done

@SheetJSDev SheetJSDev merged commit 465445e into SheetJS:master Jul 25, 2014
@SheetJSDev
Copy link
Contributor

@jjstewart can you confirm that version 0.7.1 works?

@jjstewart
Copy link
Contributor Author

Yeah I won't be able to test until Tuesday
On Jul 27, 2014 10:19 PM, "SheetJSDev" [email protected] wrote:

@jjstewart https://github.com/jjstewart can you confirm that version
0.7.1 works?


Reply to this email directly or view it on GitHub
SheetJS/sheetjs#48 (comment).

@jjstewart
Copy link
Contributor Author

@SheetJSDev tested and working.
Steps:
install js-xls with bower: bower install js-xls --save
run grunt serve: grunt serve
open dev tools and check network tab to verify xls.js injection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants