added check for module as well as require for node environment #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using requireJS in the browser, it attempts to load modules defined by require(). Not sure if these can be configured to load in browser too but quick fix is just to add extra check to ensure node environment.
redchair123
added a commit
that referenced
this pull request
Nov 22, 2013
added check for module as well as require for node environment
|
looks good! Can you also take a gander at https://github.com/SheetJS/js-xlsx and see if similar changes should be made there? |
phola
referenced
this pull request
in phola/js-xlsx
Nov 22, 2013
redchair123
referenced
this pull request
in SheetJS/sheetjs
Dec 6, 2013
SheetJSDev
added a commit
that referenced
this pull request
Dec 6, 2013
added check for module as well as require for node environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - thanks for the work on this, it's been a life saver for me this week! Hope this is useful:
When using requireJS in the browser, it attempts to load modules defined
by require(). Not sure if these can be configured to load in browser too
but quick fix is just to add extra check to ensure node environment.