Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic argument count validation #124

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Conversation

mohammedsahl
Copy link
Contributor

Reason for addition: Accidentally ran the powershell command without a directory argument. It was working fine when, 20 minutes in, I realized it was opening node_module files. Had it not been for the Skipping has pwd... message I wouldn't have realized 😄 A more thorough validation can be added in the future.

Copy link
Contributor

@wlawt wlawt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this help flag!

@wlawt wlawt merged commit 5aa1787 into master Jul 20, 2020
@wlawt wlawt deleted the hotfix-add-argument-validation branch July 20, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants