Allow IParagraphPortion.Font to be null #713
Open
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drasmith, thank you for the Pull Request! Could you please provide a unit test for these changes. |
ashahabov
reviewed
Jun 21, 2024
| paint.TextSize = (float)firstPortion.Font.Size; | ||
| var typeFace = SKTypeface.FromFamilyName(firstPortion.Font.LatinName); | ||
| paint.TextSize = (float)(firstPortion.Font?.Size ?? 11); | ||
| var typeFace = SKTypeface.FromFamilyName(firstPortion.Font?.LatinName ?? "Arial"); |
There was a problem hiding this comment.
If I'm not mistaken, the default font in the latest PowerPoint is "Aptos". Please change this.
There was a problem hiding this comment.
@drasmith, did you have time to check this out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our usage, we found instances where TextFrame.ShrinkText would throw a null reference exception due to ContentFrames not having font's for every portion. Changed IParagraphPortion to be nullable and cleaned up code so that it can skip null fonts
PR-Codex overview
This PR updates nullable references in text handling classes for font properties.
Detailed summary
Fontproperty nullable inIParagraphPortion.cs.IParagraph.cs.TextFrame.cs.