Some simple renames for better readability as suggested by Marcus

Shadytel · Apr 16, 2024 · 266424f · 266424f
1 parent 67a8e0b
commit 266424f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/database/factories/AssetFactory.php b/database/factories/AssetFactory.php
@@ -353,9 +353,9 @@ public function nonrequestable()
  return $this->state(['requestable' => false]);
  }
 
- public function has_encrypted_custom_field()
+ public function hasEncryptedCustomField()
  {
- return $this->state(['model_id' => AssetModel::where('name', 'asset with encrypted field')->first() ?? AssetModel::factory()->encrypted_field()]);
+ return $this->state(['model_id' => AssetModel::where('name', 'asset with encrypted field')->first() ?? AssetModel::factory()->withEncryptedField()]);
  }
 
 

diff --git a/database/factories/AssetModelFactory.php b/database/factories/AssetModelFactory.php
@@ -431,7 +431,7 @@ public function ultrasharp()
  });
  }
 
- public function encrypted_field()
+ public function withEncryptedField()
  {
  return $this->state(function () {
  $field = CustomField::factory()->testEncrypted()->create(); // TODO - having to create and then 'find' the thing you just created is WEIRD

diff --git a/tests/Feature/Api/Assets/AssetStoreTest.php b/tests/Feature/Api/Assets/AssetStoreTest.php
@@ -485,7 +485,7 @@ public function testCompanyIdNeedsToBeInteger()
  public function testEncryptedCustomField()
  {
  $field = CustomField::factory()->testEncrypted()->create();
- $asset = Asset::factory()->has_encrypted_custom_field()->create();
+ $asset = Asset::factory()->hasEncryptedCustomField()->create();
  $superuser = User::factory()->superuser()->create();
  $normal_user = User::factory()->editAssets()->create();