Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(prerequisites): supported python versions #42

Merged
merged 1 commit into from
May 31, 2023

Conversation

zarifpour
Copy link
Contributor

In another PR I am preparing, I am adding poetry to manage dependencies. Since no version is specified in the requirements.txt it defaults to torch = "^2.0.1".

Depending on our recommended version of torch, the earliest version of python supported is Python 3.6 (according to ChatGPT).

The current project's Python requirement (>=3.0,<4.0) is not compatible with some of the required packages Python requirement:
  - torch requires Python >=3.8.0, so it will not be satisfied for Python >=3.0,<3.8.0

I recommend updating this line to 3.8, but if you'd like to support 3.6, I think that is an acceptable version, depending on the requirements.

The current project's Python requirement (>=3.0,<4.0) is not compatible with some of the required packages Python requirement:
  - torch requires Python >=3.8.0, so it will not be satisfied for Python >=3.0,<3.8.0
@zarifpour zarifpour changed the title Update README.md docs(prerequisites): supported python versions May 31, 2023
@SevaSk SevaSk self-requested a review May 31, 2023 13:08
Copy link
Owner

@SevaSk SevaSk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SevaSk SevaSk merged commit cd441b4 into SevaSk:main May 31, 2023
@zarifpour zarifpour deleted the patch-1 branch May 31, 2023 14:08
@bilalmir
Copy link

What about torch version?
It shows ERROR: Could not find a version that satisfies the requirement torch==1.13.1+cpu (from versions: none)
ERROR: No matching distribution found for torch==1.13.1+cpu for almost for every version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants