Added Multilingual functionality #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added space
added spaces
removed unused variable
added space
removed the mistaked task
corrected the file name
SevaSk
requested changes
May 26, 2023
kbakdev
approved these changes
May 31, 2023
SevaSk
requested changes
May 31, 2023
SevaSk
reviewed
May 31, 2023
SevaSk
requested changes
May 31, 2023
SevaSk
reviewed
May 31, 2023
SevaSk
reviewed
May 31, 2023
SevaSk
reviewed
Jun 1, 2023
SevaSk
requested changes
Jun 1, 2023
| @@ -93,7 +93,7 @@ While Ecoute provides real-time transcription and response suggestions, there ar | |||
|
|
|||
| **Whisper Model**: If the --api flag is not used, we utilize the 'tiny' version of the Whisper ASR model, due to its low resource consumption and fast response times. However, this model may not be as accurate as the larger models in transcribing certain types of speech, including accents or uncommon words. | |||
|
|
|||
| **Language**: If you are not using the --api flag the Whisper model used in Ecoute is set to English. As a result, it may not accurately transcribe non-English languages or dialects. We are actively working to add multi-language support to future versions of the program. | |||
| **Language**: If you are not using the --api flag the Whisper model used in Ecoute is set to English. As a result, it may not accurately transcribe non-English languages or dialects. The multi-language support works with local models only and is not compatible with --api. | |||
There was a problem hiding this comment.
Sry for asking for this change! --api has multi-language support now so we can get rid of this limitation altogether.
|
|
||
| def main(): | ||
| root = ctk.CTk() | ||
| transcript_textbox, response_textbox, update_interval_slider, update_interval_slider_label, freeze_button = create_ui_components(root) | ||
| transcript_textbox, response_textbox, update_interval_slider, update_interval_slider_label, freeze_button, combobox = create_ui_components(root) |
There was a problem hiding this comment.
Sry for asking for more changes incrementally but could this new box only appear when we are not in --api mode? Keep in mind good design practices and group this all --api and non --api functionally together.
There was a problem hiding this comment.
I am new to this so I don't really know what good design practices are but I've tried to group them together.
Truewarlock
reviewed
Jun 2, 2023
| @@ -79,6 +83,8 @@ def main(): | |||
| speaker_audio_recorder.record_into_queue(audio_queue) | |||
|
|
|||
| model = TranscriberModels.get_model('--api' in sys.argv) | |||
| combobox.configure(command=model.change_lang) | |||
|
|
|||
There was a problem hiding this comment.
Small tip: is this extra blank line at 87 needed?
There was a problem hiding this comment.
No it isn't. Fixed it thanks!
Truewarlock
approved these changes
Jun 2, 2023
|
I think that this is ready to be merged now @SevaSk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second commit was for formatting.