Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dropdown and "tried" to implement translation #21

Closed
wants to merge 8 commits into from
Closed

Added Dropdown and "tried" to implement translation #21

wants to merge 8 commits into from

Conversation

Adarsha-gg
Copy link

I created the dropbox it can be edited to add new languages. I also added the preffered_language variable so that the value of the dropbox goes to the class so it can be accessed but I couldn't find a way to actually translate the transcript in real time. This is same as the last pull request I closed with the only change being the whisper's model.

AudioTranscriber.py Outdated Show resolved Hide resolved
AudioTranscriber.py Outdated Show resolved Hide resolved
AudioTranscriber.py Outdated Show resolved Hide resolved
AudioTranscriber.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
Copy link
Owner

@SevaSk SevaSk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I cannot merge this PR yet I have left some comment with feedback.

@Adarsha-gg
Copy link
Author

Adarsha-gg commented May 24, 2023 via email

@SevaSk
Copy link
Owner

SevaSk commented May 24, 2023

Here is the whisper documentation
https://github.com/openai/whisper/blob/main/README.md

we would want to use the language flag so the line would look something like
self.audio_model.transcribe(file_path, fp16=torch.cuda.is_available(), language= "The ISO 2 Letter Language Codes")

removed unused variable
added space
@Adarsha-gg
Copy link
Author

Adarsha-gg commented May 24, 2023 via email

removed the mistaked task
corrected the file name
@SevaSk
Copy link
Owner

SevaSk commented May 25, 2023

Whisper can definitely transcribe other languages if you get the feature complete and fully working please feel free to open another pull request! I cant merge this one if the feature is not fully implemented.

@SevaSk SevaSk closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants