AHCIController: Fix off-by-one mistake #7144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes off-by-one caused by reading the register directly without adding a 1 to it, because AHCI reports 1 less port than the actual number of ports supported.
|
mind making the commit message a bit more descriptive? |
ElectrodeYT
force-pushed
the
ahci-off-by-one
branch
from
cec14b4
to
addcac2
Compare
|
Yeah, just added the description to the commit |
|
Great finding! I forgot that the register that indicates how much ports we have is actually the count minus 1.... |
awesomekling
changed the title
Hendiadyoin1
pushed a commit
to Hendiadyoin1/serenity
that referenced
this pull request
May 24, 2021
Fixes off-by-one caused by reading the register directly without adding a 1 to it, because AHCI reports 1 less port than the actual number of ports supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes off-by-one caused by reading the register directly without adding a 1 to it, because AHCI reports 1 less port than the actual number of ports supported.