Ports: Add flatbuffers library #6050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ef1733
to
0c720ef
Compare
awesomekling
reviewed
Apr 1, 2021
Comment on lines
29
to
31
| + #ifdef __serenity__ | ||
| + #define PATH_MAX 4096 | ||
| + #endif |
There was a problem hiding this comment.
The correct way (according to Dr. POSIX) to get PATH_MAX is to make sure <limits.h> is included.
There was a problem hiding this comment.
Oh, sorry, I forgot about <limits.h>...
But a weird thing: the file I patched already includes this header
#ifdef _WIN32
# ifndef WIN32_LEAN_AND_MEAN
# define WIN32_LEAN_AND_MEAN
# endif
# ifndef NOMINMAX
# define NOMINMAX
# endif
# ifdef _MSC_VER
# include <crtdbg.h>
# endif
# include <windows.h>
# include <direct.h>
# include <winbase.h>
# undef interface
#else
# define _XOPEN_SOURCE 600
# include <limits.h> // <----------
#endif
// clang-format on(the complete file is here )
I will try to compile a test program to investigate
There was a problem hiding this comment.
I investigated. It was something with my toolchain
I recompiled it and it worked
The flatbuffers library is a serialization library, created by Google for game development and performance-critical applications. It aims to be fast and efficient. This commit creates a port of it to SerenityOS. The flatbuffers build process generates three things: some header files, a library (libflatbuffers) and a schema compiler (flatc). There are tests, but they are not compiled, because it runs the flatbuffers schema compiler, one of the things we are cross-compiling. The compiler will not run because the target is different from the host
PATH_MAX was already defined in <limits.h>, a file that already has been included in the file we were patching So, no need to patch that file at all
0c720ef
to
b407583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flatbuffers library is a serialization library, created by Google for game development and performance-critical applications.
It aims to be fast and efficient.
This commit creates a port of it to SerenityOS.
Although this library is not much popular among the bigger opensource projects, there are some uses of it here on Github. If someone happens to port any small game that uses flatbuffers, it would be one less dependency for the person to port
The flatbuffers build process generates three things: some header files, a library (libflatbuffers) and a schema compiler (flatc).
A small caveat of this port: the library comes with a test suite, but we cannot run it, because it attempts to run the flatc executable we are compiling to SerenityOS in the host system. The host system does not recognize the file format, so it fails.
Nevertheless, the port compiles and runs: the schema compiler runs and the library links successfully