Meta: Remove catchall lines in .gitignore #4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two lines caused this local .gitignore to supersede all inputs in any files specified by a user's `core.excludesFile` configuration since the first match was going to be `!*.*` for any file with a decimal or any directory. `git check-ignore -v somefile` can be used to test this.
|
All righty |
awesomekling
changed the title
awesomekling
added a commit
that referenced
this pull request
Dec 27, 2020
This reverts commit bee1774. It made our .gitignore ignore *everything*.
bgianfo
added a commit
to bgianfo/serenity
that referenced
this pull request
May 20, 2021
The wild card rules at the top of the .gitignore came from a time when the build wrote back to the git repository and placed files right next to the source. (Original commit that introduced them 37c27e2, they were later consolidated into the root .gitignore in 802d4dc) We have since moved to cmake, and these rules have become obsolete, and they just cause issues where we need to go and add negations for these rules in order for things to work. A previous change attempted to remove the top wild card rules (PR SerenityOS#4565) but it was later reverted, as they forgot to remove the top ignore everything rule '*', so all files were ignored. This change just removes all of these rules that no longer make sense, restoring a bit of sanity. *.o,*.d,*.a rules were also from when the build wrote to the repository, they are now defunct. The same goes for the *Endpoint.h and CMakeFiles rules. The lowercase build directory can be removed as we've standardized on the uppercase 'Build' directory as the root of the build output dir.
awesomekling
pushed a commit
that referenced
this pull request
May 20, 2021
The wild card rules at the top of the .gitignore came from a time when the build wrote back to the git repository and placed files right next to the source. (Original commit that introduced them 37c27e2, they were later consolidated into the root .gitignore in 802d4dc) We have since moved to cmake, and these rules have become obsolete, and they just cause issues where we need to go and add negations for these rules in order for things to work. A previous change attempted to remove the top wild card rules (PR #4565) but it was later reverted, as they forgot to remove the top ignore everything rule '*', so all files were ignored. This change just removes all of these rules that no longer make sense, restoring a bit of sanity. *.o,*.d,*.a rules were also from when the build wrote to the repository, they are now defunct. The same goes for the *Endpoint.h and CMakeFiles rules. The lowercase build directory can be removed as we've standardized on the uppercase 'Build' directory as the root of the build output dir.
Coderdreams
pushed a commit
to Coderdreams/serenity
that referenced
this pull request
May 22, 2021
The wild card rules at the top of the .gitignore came from a time when the build wrote back to the git repository and placed files right next to the source. (Original commit that introduced them 37c27e2, they were later consolidated into the root .gitignore in 802d4dc) We have since moved to cmake, and these rules have become obsolete, and they just cause issues where we need to go and add negations for these rules in order for things to work. A previous change attempted to remove the top wild card rules (PR SerenityOS#4565) but it was later reverted, as they forgot to remove the top ignore everything rule '*', so all files were ignored. This change just removes all of these rules that no longer make sense, restoring a bit of sanity. *.o,*.d,*.a rules were also from when the build wrote to the repository, they are now defunct. The same goes for the *Endpoint.h and CMakeFiles rules. The lowercase build directory can be removed as we've standardized on the uppercase 'Build' directory as the root of the build output dir.
Hendiadyoin1
pushed a commit
to Hendiadyoin1/serenity
that referenced
this pull request
May 24, 2021
The wild card rules at the top of the .gitignore came from a time when the build wrote back to the git repository and placed files right next to the source. (Original commit that introduced them 37c27e2, they were later consolidated into the root .gitignore in 802d4dc) We have since moved to cmake, and these rules have become obsolete, and they just cause issues where we need to go and add negations for these rules in order for things to work. A previous change attempted to remove the top wild card rules (PR SerenityOS#4565) but it was later reverted, as they forgot to remove the top ignore everything rule '*', so all files were ignored. This change just removes all of these rules that no longer make sense, restoring a bit of sanity. *.o,*.d,*.a rules were also from when the build wrote to the repository, they are now defunct. The same goes for the *Endpoint.h and CMakeFiles rules. The lowercase build directory can be removed as we've standardized on the uppercase 'Build' directory as the root of the build output dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two lines caused this local .gitignore to supersede all inputs
in any files specified by a user's
core.excludesFileconfigurationsince the first match was going to be
!*.*for any file with adecimal or any directory.
git check-ignore -v somefilecan be used totest this.