LibCore: Rename identifiers that can clash with libc macros #4127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't feel like a very sturdy fix. What happens to code that includes |
|
Agreed, undefining them is not great, let's rename ours instead. |
|
Any suggestions for the names? |
|
Perhaps |
|
I vote standard_input(), I feel like it makes the most sense. |
|
Sorry for the time it took! Should follow the proposed solution now. |
ericonr
changed the title
…c macros. POSIX allows the default streams (stdin, stdout and stderr) to be macros, which means that on such systems (musl libc is one) building Lagom will fail due to the File::std*() names. Also fix any files that use these identifiers.
|
It also passes CI now :D |
awesomekling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX allows these default streams to be macros, which means that on
such systems (musl libc is one) building Lagom will fail due to the
File::stdin() functions. Undefining them at the top of the file is
enough to fix it.