GFilePicker: Quality of life improvements. Fixes (#367) #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awesomekling
requested changes
Jul 28, 2019
Libraries/LibGUI/GFilePicker.cpp
Outdated
| @@ -48,7 +48,7 @@ GFilePicker::GFilePicker(Mode mode, const StringView& path, CObject* parent) | |||
| , m_model(GDirectoryModel::create()) | |||
| , m_mode(mode) | |||
| { | |||
| set_title("GFilePicker"); | |||
| set_title(m_mode == Mode::Open ? "GFilePicker: Open File" : "GFilePicker: Save File"); | |||
There was a problem hiding this comment.
Let's get rid of "GFilePicker: " and just say "Open File" or "Save File"
Added: -Default to home directory on open -Save Button Focous. -Correct title for the mode were in -Home shortcut
RyanGrieb
force-pushed
the
filepicker-fix
branch
from
0f87d07
to
23ca94f
Compare
|
This should be done too |
|
Stellar! |
RyanGrieb
added a commit
to RyanGrieb/serenity
that referenced
this pull request
Jul 28, 2019
Added: - Default to home directory on open. - Save button focus. - Correct title for the mode were in. - Home directory shortcut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried adding key events to GDialog to allow ESC on exit but the components in the dialog weren't loading when the event function (from CObject) was being overwritten. Is the event being constantly called which is preventing us from going any further?