Userland: Improve head program #155
Conversation
Userland/head.cpp
Outdated
| if (!str) | ||
| break; | ||
| fputs(str, stdout); | ||
| printf("%s", str); |
There was a problem hiding this comment.
I would keep the old version of this code. fputs() avoids having to parse the format string since it's just "%s" anyway.
There was a problem hiding this comment.
The reason I changed it to the printf call instead was to avoid the newline from puts doubling up with the newline from the source data. I've changed this to instead strip the trailing newline from the source string, and made this into a puts call. I didn't make it fputs because I can't think of any reason we'd want to output to anything other than stdout.
deoxxa
force-pushed
the
userland-improve-head
branch
from
e629a5e
to
40c5f11
Compare
Userland/head.cpp
Outdated
| if ((pos = strchr(str, '\n')) != nullptr) | ||
| *pos = '\0'; | ||
|
|
||
| puts(str); |
There was a problem hiding this comment.
fputs(str, stdout) doesn't add a newline while puts(str) does.
A silly ancient C library artifact (of many) :)
There was a problem hiding this comment.
Oh! Well, now that original code makes sense. Thanks for bearing with me!
* allow specifying files as arguments, e.g. `head a b c` * support multiple files * print a filename header when multiple files are being printed * allow suppression or forcing of filename header via flags This change drops support for the legacy `-123` syntax in favour of the more widely-supported `-n 123` form. fixes SerenityOS#105
deoxxa
force-pushed
the
userland-improve-head
branch
from
40c5f11
to
218a161
Compare
|
Excellent! Thanks for working on this :) |
head a b cThis change drops support for the legacy
-123syntax in favour of themore widely-supported
-n 123form.fixes #105