Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Avoid copying viewport rect when converting length to pixels #15203

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

networkException
Copy link
Member

I couldn't believe it myself but its apparently been over two years since I started contributing. Back then I had barely any knowledge of C++ (most of which came from watching Andreas' videos anyways), git and all the fun things that go into an operating system.

Since then I've learnt so much and met so many cool people - I'm incredibly grateful for it!

One of my first contributions was to implement the v{w,h,min,max} length units in LibWeb. In the review linus requested that I don't copy the viewport rect every time to read some simple int values from it. As I didn't know what a const reference was and had no clue about squashing commits Andreas simply let it go through.

This pull request fixes this very minor performance issue. If it doesn't get merged due to being a micro optimization with no measured impact I'll happily contribute another change as my 100th commit, though it will not have any lore attached :^) :^)

Copy link
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bruh how has it been two years since I started reviewing serenity code

@linusg linusg merged commit 9ff6c1e into SerenityOS:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants