Documentation: Specify that no new code should contain C-style casts #14051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADKaster
reviewed
May 15, 2022
kleinesfilmroellchen
force-pushed
the
castaways
branch
2 times, most recently
from
ce2e347
to
b27a67c
Compare
alimpfard
reviewed
May 15, 2022
Let's move towards a C-style-cast-free code base.
kleinesfilmroellchen
force-pushed
the
castaways
branch
from
b27a67c
to
dc8e23f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion (relative) consensus. Let's move towards a C-style-cast-free code base.
At some point this will hopefully help us with #5487, but no enabling of warnings can be done right now.