AK: Move the implementations of to_int() and to_uint() from String and StringView to AK::StringUtils #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StringView to AK::StringUtils Provide wrappers in String and StringView. Add some tests for the implementations.
|
Please try to keep lines in commit messages 72 characters or shorter :) |
|
ok! |
nimelehin
pushed a commit
to nimelehin/serenity
that referenced
this pull request
Apr 12, 2020
…OS#1338) Provide wrappers in String and StringView. Add some tests for the implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide wrappers in String and StringView. Add some tests for the implementations.