-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji 🔥😄🤦🚀 #490
Comments
🦄🦄🦄 |
Here is the Emoji spec as a friendly warning for those brave souls who wants to work on this issue: https://www.unicode.org/reports/tr51/ |
We should probably share color emoji glyphs between fonts; then it makes sense not to embed them into the fonts themselves. And I think we should just store them as regular icons in |
Utf8View wraps a StringView and implements begin() and end() that return a Utf8CodepointIterator, which parses UTF-8-encoded Unicode codepoints and returns them as 32-bit integers. This is the first step towards supporting emojis in Serenity ^) SerenityOS#490
Utf8View wraps a StringView and implements begin() and end() that return a Utf8CodepointIterator, which parses UTF-8-encoded Unicode codepoints and returns them as 32-bit integers. This is the first step towards supporting emojis in Serenity ^) SerenityOS#490
Utf8View wraps a StringView and implements begin() and end() that return a Utf8CodepointIterator, which parses UTF-8-encoded Unicode codepoints and returns them as 32-bit integers. This is the first step towards supporting emojis in Serenity ^) #490
Having fallback font support and an Emoji-only font to be used as a fallback for the normal fonts would be an another way to solve this. |
That is kind of what we're doing; but instead of making an actual emoji font we're storing the emoji set differently. The reason is actual fonts (256 mmappable black-and-white glyphs) and the emoji set (few color PNGs we need to look up by codepoint) are different enough it makes sense to store and process them differently. We could generalize the font format to include some sort of a mapping table from codepoints to glyph offsets and to support more than simple bitmaps... but this seems to be a clearer solution so far |
This class can locate and load emojis, which are expected to be stored as regular PNG images at /res/emoji/U+XXXX.png, where XXXX is the character codepoint. SerenityOS#490
From here on, all strings displayed to the user are expected to be encoded as UTF-8. The next few commits will deal with a few existing places where this requirement is currently violated. SerenityOS#490
This class can locate and load emojis, which are expected to be stored as regular PNG images at /res/emoji/U+XXXX.png, where XXXX is the character codepoint. SerenityOS#490
From here on, all strings displayed to the user are expected to be encoded as UTF-8. The next few commits will deal with a few existing places where this requirement is currently violated. SerenityOS#490
This class can locate and load emojis, which are expected to be stored as regular PNG images at /res/emoji/U+XXXX.png, where XXXX is the character codepoint. SerenityOS#490
From here on, all strings displayed to the user are expected to be encoded as UTF-8. The next few commits will deal with a few existing places where this requirement is currently violated. SerenityOS#490
This class can locate and load emojis, which are expected to be stored as regular PNG images at /res/emoji/U+XXXX.png, where XXXX is the character codepoint. #490
From here on, all strings displayed to the user are expected to be encoded as UTF-8. The next few commits will deal with a few existing places where this requirement is currently violated. #490
@bugaevc Can this issue be closed now?! |
Maybe? We still don't have a way to type emojis, and text editor still doesn't support them |
We have everything in place now 😄 |
Hell yeah! 🤔 |
We've agreed that we want (color) emoji support in Serenity! 😄 👍
Painter
(@bugaevc)The text was updated successfully, but these errors were encountered: