Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibGUI: IconView doesn't show item text when scrolling and selecting items #4040

Closed
tomuta opened this issue Nov 10, 2020 · 1 comment · Fixed by #4045
Closed

LibGUI: IconView doesn't show item text when scrolling and selecting items #4040

tomuta opened this issue Nov 10, 2020 · 1 comment · Fixed by #4045

Comments

@tomuta
Copy link
Collaborator

tomuta commented Nov 10, 2020

This seems like a very recent regression:

iconview_no_text
@AmusedNetwork
Copy link
Contributor

Looks like it was my change (eac0344) - will look into it now.

AmusedNetwork pushed a commit to AmusedNetwork/serenity that referenced this issue Nov 11, 2020
LibGUI: Set vertical distance between icons relative to scroll value
bdf0a0c 
When calculating the vertical distance between icons, we should take
into account the value of the vertical scrollbar.

Fixes SerenityOS#4040
@AmusedNetwork AmusedNetwork mentioned this issue Nov 11, 2020
Merged
awesomekling pushed a commit that referenced this issue Nov 11, 2020
@awesomekling
LibGUI: Set vertical distance between icons relative to scroll value
de6483b 
When calculating the vertical distance between icons, we should take
into account the value of the vertical scrollbar.

Fixes #4040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LibGUI: Set vertical distance between icons relative to scroll value AmusedNetwork/serenity
2 participants
@AmusedNetwork @tomuta