Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel: Buffer overflow in dump_backtrace_impl #371

Closed
DrewStratford opened this issue Jul 28, 2019 · 0 comments · Fixed by #372
Closed

Kernel: Buffer overflow in dump_backtrace_impl #371

DrewStratford opened this issue Jul 28, 2019 · 0 comments · Fixed by #372

Comments

@DrewStratford
Copy link
Contributor

There's buffer overflow in dump_backtrace_impl. In line 99 of KSyms.cpp we write to recognized_symbols without checking whether recognized_symbol_count is within bounds.
This could likely cause issues when dumping a backtrace for a program that overflowed the stack.
@DrewStratford DrewStratford mentioned this issue Jul 28, 2019
Merged
awesomekling pushed a commit that referenced this issue Jul 28, 2019
@DrewStratford @awesomekling
Kernel: Add bounds checking to recognized_symbols in dump_backtrace_i…
608fee9 
…mpl (#372)

This adds a bounds check to the loop that writes to the buffer
'recognized_symbols'. This prevents buffer overflows in the
case when a programs backtrace is particularly large.

Fixes #371.
RyanGrieb pushed a commit to RyanGrieb/serenity that referenced this issue Jul 28, 2019
@DrewStratford @RyanGrieb
Kernel: Add bounds checking to recognized_symbols in dump_backtrace_i…
506a32d 
…mpl (SerenityOS#372)

This adds a bounds check to the loop that writes to the buffer
'recognized_symbols'. This prevents buffer overflows in the
case when a programs backtrace is particularly large.

Fixes SerenityOS#371.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bounds checking to recognized_symbols in dump_backtrace_impl DrewStratford/serenity
1 participant
@DrewStratford