LibCore: Socket takeover delimiter is too limiting

[ADKaster]

We currently allow processes to pass multiple socket paths in the SOCKET_TAKEOVER environment variable. The logic for pulling either a specific socket or the first socket uses ' ' as the delimiter between different sockets.

We ran into this with SQLServer on macOS, where the initial approach set the socket "name" as the path to the socket.

SOCKET_TAKEOVER=/path/to/socket:<socket_fd_number>

This works great until the path has a space in it, like /Users/me/Library/Application Support/SQLServer.socket.

A more robust delimiter between different socket name/fd pairs would probably be better, such as ;.

[kleinesfilmroellchen]

ah, the old 'spaces break 90% of path handling code' issue. I'd suggest : as that is the standard UNIX path separator, also used in $PATH for example. nvm I'm dumb, ; seems fine. Reminder to any implementor that this needs to be documented with the socket takeover mechanism.

[ADKaster]

But we use : to separate the socket name from the FD already. It would be prudent to not re-use the same delimiter for different purposes.