Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Window title updated incorrectly #1259

Closed
xTibor opened this issue Feb 21, 2020 · 4 comments
Closed

Help: Window title updated incorrectly #1259

xTibor opened this issue Feb 21, 2020 · 4 comments

Comments

@xTibor
Copy link
Contributor

xTibor commented Feb 21, 2020

When opening a manual page the Help app sets the window title based on the currently selected tree view node, not the actual manual page path passed to the open_page function. This causes incorrect window titles when following hyperlinks in the document or navigating through the history.

@shannonbooth
Copy link
Member

shannonbooth commented Feb 21, 2020

I think it would make sense if following a hyperlink in Help would update the tree view selection to that item.

@shannonbooth
Copy link
Member

shannonbooth commented Feb 21, 2020

Also, following some of the hyperlinks in Help seems to lead to a blank page for me? e.g the mount(8) link in mount(2) - and vice versa

@xTibor
Copy link
Contributor Author

xTibor commented Feb 21, 2020

The blank pages are caused by the /.. unveil bug:

// FIXME: Figure out a nicer way to do this.
if (String(path).contains("/.."))
return KResult(-EINVAL);

@shannonbooth
Copy link
Member

Made #1260 as I forgot about that bug. Kinda makes me want to do some Kernel work, but me reckons I already do enough low level kernel/bootloader work at my day job. IAlways nice to write some higher level code every so often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants