-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help: Window title updated incorrectly #1259
Comments
I think it would make sense if following a hyperlink in Help would update the tree view selection to that item. |
Also, following some of the hyperlinks in Help seems to lead to a blank page for me? e.g the mount(8) link in mount(2) - and vice versa |
The blank pages are caused by the serenity/Kernel/FileSystem/VirtualFileSystem.cpp Lines 724 to 726 in 1d2986e
|
Made #1260 as I forgot about that bug. Kinda makes me want to do some Kernel work, but me reckons I already do enough low level kernel/bootloader work at my day job. IAlways nice to write some higher level code every so often. |
When opening a manual page the Help app sets the window title based on the currently selected tree view node, not the actual manual page path passed to the
open_page
function. This causes incorrect window titles when following hyperlinks in the document or navigating through the history.The text was updated successfully, but these errors were encountered: