Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-printable characters should probably be sanitized from ls output #1044

Closed
xTibor opened this issue Jan 8, 2020 · 1 comment · Fixed by #1082
Closed

Non-printable characters should probably be sanitized from ls output #1044

xTibor opened this issue Jan 8, 2020 · 1 comment · Fixed by #1082

Comments

@xTibor
Copy link
Contributor

xTibor commented Jan 8, 2020

Reproduction:

Where is says <ESC> press the actual escape key.

$ touch "<ESC><ESC>[93;41mhello friends"
$ ls -al

Screenshot_20200108_234852
@jcs
Copy link
Member

jcs commented Jan 9, 2020

Probably anything that fails isprint() should be escaped.

@xTibor xTibor changed the title VT100 escape sequences should probably be sanitized from ls output Non-printable characters should probably be sanitized from ls output Jan 10, 2020
jcs added a commit to jcs/serenity that referenced this issue Jan 15, 2020
@jcs
Userland/ls: escape non-printable characters
42cb566 
Fixes SerenityOS#1044
jcs added a commit to jcs/serenity that referenced this issue Jan 15, 2020
@jcs
Userland/ls: escape non-printable characters
e7ec0d2 
Fixes SerenityOS#1044
@jcs jcs mentioned this issue Jan 15, 2020
Merged
awesomekling pushed a commit that referenced this issue Jan 15, 2020
@jcs @awesomekling
Userland/ls: escape non-printable characters
d7e8431 
Fixes #1044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Userland/ls: escape non-printable characters jcs/serenity
2 participants
@jcs @xTibor