Meta: Set 'pipefail' option correctly in shell scripts

This needs '-o' to work correctly. Also update the shebang to bash in some scripts as shellcheck was complaining about pipefail not being a POSIX shell thing otherwise.
SerenityOS · Dec 27, 2020 · a56b3cb · a56b3cb
1 parent 5122f98
commit a56b3cb
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/Meta/lint-executable-resources.sh b/Meta/lint-executable-resources.sh
@@ -1,5 +1,6 @@
-#!/bin/sh
-set -e pipefail
+#!/bin/bash
+
+set -eo pipefail
 
 script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
 cd "$script_path/.."

diff --git a/Meta/lint-ipc-ids.sh b/Meta/lint-ipc-ids.sh
@@ -1,5 +1,6 @@
-#!/bin/sh
-set -e pipefail
+#!/bin/bash
+
+set -eo pipefail
 
 script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
 cd "$script_path/.."

diff --git a/Meta/lint-missing-resources.sh b/Meta/lint-missing-resources.sh
@@ -1,5 +1,6 @@
-#!/bin/sh
-set -e pipefail
+#!/bin/bash
+
+set -eo pipefail
 
 script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
 cd "$script_path/.."

diff --git a/Meta/lint-shell-scripts.sh b/Meta/lint-shell-scripts.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
-set -e pipefail
+
+set -eo pipefail
 
 script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
 cd "$script_path/.."