Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Return Task instead of wait it in generated CDP method invocations #12672

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

nvborisenko
Copy link
Member

Description

Generated code for CDP is

public async Task Do()
{
  return await DoSomethingElse();
}

We can refactor it to

public Task Do()
{
  return DoSomethingElse();
}

Pros:

  • More performant
  • Compiler generates less IL code (dll size before: 6.5MB, after: 4.5MB)

Cons:

  • Exceptions. raised by DoSomethingElse() method, don't indicate Do() method in stacktrace

Motivation and Context

Improve this amazing library.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol merged commit f664536 into SeleniumHQ:trunk Sep 4, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants