Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Allow to change default folder for Selenium Manager cache (#11688) #12514

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR allows to change the default cache folder for Selenium Manager. For instance:

> selenium-manager --browser chrome --debug --cache-path C:\Users\boni\Downloads\se

DEBUG   chromedriver not found in PATH
DEBUG   chrome detected at C:\Program Files\Google\Chrome\Application\chrome.exe
DEBUG   Running command: wmic datafile where name='C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe' get Version /value
DEBUG   Output: "\r\r\n\r\r\nVersion=115.0.5790.111\r\r\n\r\r\n\r\r\n\r"
DEBUG   Detected browser: chrome 115.0.5790.111
DEBUG   Reading metadata from https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json
DEBUG   Required driver: chromedriver 115.0.5790.170
DEBUG   Driver URL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5790.170/win64/chromedriver-win64.zip
INFO    Driver path: C:\Users\boni\Downloads\se\chromedriver\win64\115.0.5790.170\chromedriver.exe
INFO    Browser path: C:\Program Files\Google\Chrome\Application\chrome.exe

As usual, the new CLI flag (--cache-path) can be overridden using the configuration file (key cache-path) or using an environment variable (SE_CACHE_PATH).

Motivation and Context

This PR implements #11688.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (efefbc9) 57.26% compared to head (dfaad47) 57.26%.

❗ Current head dfaad47 differs from pull request most recent head f4fa3fa. Consider uploading reports for the commit f4fa3fa to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12514   +/-   ##
=======================================
  Coverage   57.26%   57.26%           
=======================================
  Files          86       86           
  Lines        5335     5335           
  Branches      198      198           
=======================================
  Hits         3055     3055           
  Misses       2082     2082           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bonigarcia bonigarcia force-pushed the sm_cache_path branch 2 times, most recently from 55e8b37 to 7c34743 Compare August 7, 2023 22:18
@bonigarcia bonigarcia merged commit b89fb5e into trunk Aug 8, 2023
49 of 53 checks passed
@bonigarcia bonigarcia deleted the sm_cache_path branch August 8, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants