Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Change default type (arch, os) for binaries downloaded by Selenium Manager (#11685) #12485

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR allows to change the default architecture and operating system for the browser/drivers managed by Selenium Manager. This configuration, as usual, can be done in three ways:

  1. CLI flags (--os OS and --arch ARCH)
  2. Configuration file (os = "OS" and arch = "ARCH")
  3. Environment variables (SE_OS=OS and SE_ARCH=ARCH)

Motivation and Context

This PR implements #11685. Also, it allows to give consistency to the configuration table published in the Selenium Manager page.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol
Copy link
Member

diemol commented Aug 4, 2023

I merged another PR that caused conflicts, sorry.

@bonigarcia
Copy link
Member Author

No problem, I have just fixed the conflicts.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (3df8b70) 57.26% compared to head (e2920d9) 57.26%.
Report is 2 commits behind head on trunk.

❗ Current head e2920d9 differs from pull request most recent head cc8902a. Consider uploading reports for the commit cc8902a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12485   +/-   ##
=======================================
  Coverage   57.26%   57.26%           
=======================================
  Files          86       86           
  Lines        5335     5335           
  Branches      198      198           
=======================================
  Hits         3055     3055           
  Misses       2082     2082           
  Partials      198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bonigarcia bonigarcia merged commit d06a6ee into trunk Aug 7, 2023
2 of 3 checks passed
@bonigarcia bonigarcia deleted the se_mgr_osarch branch August 7, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants